On Wed, 3 Dec 2025 15:43:14 GMT, Brian Burkhalter <[email protected]> wrote:
>> test/jdk/java/io/File/GetXSpace.java line 187:
>>
>>> 185: out.format("%s (%d):%n", s.name(), s.size());
>>> 186: String fmt = " %-4s total = %12d free = %12d usable = %12d%n";
>>> 187: String method = Platform.isWindows() & isCDDrive(s.name()) ?
>>> "getCDDriveSpace" : "getSpace";
>>
>> Hello Brian, pre-existing nit - for what this line is doing, the use of
>> bitwise `&` operator looks like an oversight. Should it have been `&&`?
>
> Hi @jaikiran. Indeed this looks like an ineffectual mistake but I'll fix it
> before integrating.
This and one other occurrence fixed in 973ea83.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28592#discussion_r2585679123
