On Fri, 5 Dec 2025 20:20:45 GMT, Paul Sandoz <[email protected]> wrote:

>> Xueming Shen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   minor update
>
> test/jdk/jdk/incubator/vector/templates/Unit-BoolUnary-op.template line 6:
> 
>> 4:     }
>> 5: 
>> 6:     @Test(dataProvider = "maskBinaryOpProvider")
> 
> There is already "boolUnaryOpProvider" data provider can we use that and 
> align the naming?

"boolUnaryOpProvider" is used only by the mask 
reduction/Unit-BoolReduction-op.template. Renamed it to 
"boolMaskUnaryOpProvider" to be used by both reduction and 
unary-op/Unit-BoolUnary-op.template. 

- boolMaskUnaryOpProvider
- boolMaskBinaryOpProvider
- longMaskProvider
- maskProvider

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28593#discussion_r2594291609

Reply via email to