On Fri, 12 Dec 2025 22:09:22 GMT, Alexey Semenyuk <[email protected]> wrote:

> Make jpackage ToolProvider implementation implement 
> `ToolProvider#run(PrintStream, PrintStream, String)` method such that it 
> passes `PrintWriter` objects with auto-flush enabled into 
> `ToolProvider#run(PrintWriter, PrintWriter, String)` call.

src/jdk.jpackage/share/classes/jdk/jpackage/internal/cli/Main.java line 74:

> 72:             PrintWriter outWriter = new PrintWriter(out, true);
> 73:             PrintWriter errWriter = new PrintWriter(err, true);
> 74:             try {

Looks good, but why we need two `try` blocks?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28807#discussion_r2615933489

Reply via email to