On Wed, 10 Dec 2025 01:37:05 GMT, Trevor Bond <[email protected]> wrote:
>> Add a new factory method to `IncrementInstruction` that allows the explicit >> creation of a wide iinc instruction, even with a `slot` and `constant` that >> could fit into a normal iinc instruction. Previously, only one factory for >> iinc instructions existed, which inferred the type of instruction needed >> given the size of `slot` and `constant`. Add additional test cases for the >> new factory as well. All tier 1 tests and classfile tests have passed with >> these changes. > > Trevor Bond has updated the pull request incrementally with one additional > commit since the last revision: > > Clean up javadocs and address other review comments Looks fine. Please wait patiently for the CSR review. I have created the CSR. @asotona might help review it; but the CSR review lead will be on winter break, so you might need to wait till January. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/28729#pullrequestreview-3579910365 PR Comment: https://git.openjdk.org/jdk/pull/28729#issuecomment-3657353934
