On Tue, 16 Dec 2025 00:54:31 GMT, Alexey Semenyuk <[email protected]> wrote:

>> - Append "Error: " prefix to error messages
>> - Always print stack traces of internal exceptions, not only when running in 
>> verbose mode
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   cli/Main fix ErrorTest failure

Looks good with minor comment.

test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/cli/MainTest.java
 line 371:

> 369:             return ex -> {
> 370:                 var msg = formatter.apply(ex);
> 371:                 return I18N.format("message.error-header", msg)  + 
> System.lineSeparator();

Extra space in `msg) +`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28833#pullrequestreview-3580953438
PR Review Comment: https://git.openjdk.org/jdk/pull/28833#discussion_r2621525783

Reply via email to