On Thu, 18 Dec 2025 23:01:07 GMT, Justin Lu <[email protected]> wrote:
> Please review this PR which migrates the java.time tests from TestNG to > JUnit. The java.time tests use TestNG based on the directory level settings > configured by TEST.properties, so they are best migrated altogether. This is > a large PR, so I have tried to make the changes clear by commit. > > First, the auto conversion tool is run in > https://github.com/openjdk/jdk/commit/b1fd7dbdec85aac5a44cc875e57a36be8f1b6974. > https://github.com/openjdk/jdk/commit/3805cfd8765c0c76b61893dcf1670951402f98c3 > and > https://github.com/openjdk/jdk/commit/b697ca5d9a8067bcecea2dfb32f92f7699085dee > are required so that the tests can actually compile and run. > https://github.com/openjdk/jdk/commit/d07c912c4c16d2b3307e489563f148f71cfdf4a4 > addresses the timeout annotation which was not covered by the auto > conversion tool. > The rest of the commits are aesthetic related. > > Before conversion stats > > > Test results: passed: 187 > Framework-based tests: 32,339 = 32,339 TestNG + 0 JUnit > > > After conversion stats > > > Test results: passed: 187 > Framework-based tests: 32,339 = 0 TestNG + 32,339 JUnit test/jdk/java/time/tck/java/time/AbstractDateTimeTest.java line 202: > 200: @Test > 201: public void test_get_TemporalField_invalidField() { > 202: Assertions.assertThrows(DateTimeException.class, () -> { It appears that not all the `TemporalAccessor`s from `samples()` are being tested. I want to keep the total count of tests before and after the migration the same, so handling this separate from this issue. Filed [JDK-8374051](https://bugs.openjdk.org/browse/JDK-8374051). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28911#discussion_r2632918995
