On Thu, 18 Dec 2025 11:54:41 GMT, eunbin son <[email protected]> wrote:
>> ## Summary >> Adds comprehensive edge case tests for `Objects.requireNonNull`, >> `requireNonNullElse`, and `requireNonNullElseGet` methods to improve >> test coverage. >> >> ## Problem >> The current test suite for `Objects.requireNonNull` methods covers >> basic cases but lacks edge case coverage. >> >> ## Solution >> This PR adds tests for the following edge cases: >> - requireNonNull with null Supplier parameter >> - requireNonNull with Supplier that throws exception >> - requireNonNullElse with both arguments null >> - requireNonNullElseGet with null supplier >> - requireNonNullElseGet with supplier returning null >> >> ## Issue >> Fixes JDK-8373661 >> >> **JBS Issue Link**: >> https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8373661 >> >> ## Type of Change >> - [x] Test addition/modification >> - [ ] Bug fix >> - [ ] New feature >> - [ ] Documentation improvement >> - [ ] Refactoring >> >> ## Testing >> >> make test TEST="jtreg:test/jdk/java/util/Objects" > > eunbin son has updated the pull request incrementally with one additional > commit since the last revision: > > 8373661: Address code style feedback > > - Expanded wildcard imports to individual imports > - Simplified test messages to identify tests only > - Used Assertions.fail() where appropriate > - Kept assertTrue/assertFalse for isNull API tests > > Thanks to @RogerRiggs and @liach for the feedback. test/jdk/java/util/Objects/BasicObjectsTest.java line 1: > 1: /* You can update the copyright year by running sh bin/update_copyright_year.sh -b 53ebcdbd029a1c78f8429574b78cecce70c11af2 (this refers to the last mainline commit on your PR branch) in the project root directory. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28845#discussion_r2635767910
