On Thu, 18 Dec 2025 16:46:26 GMT, Roger Riggs <[email protected]> wrote:
>> Refactor serialization tests to use JUnit.
>> Automated conversion for most annotations.
>> Conditional tests are refactored to use JUnit Enable/DisableIf.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Cleanup arglist and fix code style
test/jdk/java/io/Serializable/serialFilter/GlobalFilterTest.java line 161:
> 159: @EnabledIf("hasGlobalFilter")
> 160: @MethodSource("globalPatternElements")
> 161: void globalFilterElements(String pattern, boolean allowed,Object
> obj) {
Suggestion:
void globalFilterElements(String pattern, boolean allowed, Object obj) {
test/jdk/java/io/Serializable/serialFilter/SerialFactoryFaults.java line 80:
> 78:
> 79: if (factoryName.equals("ForcedError_NoSuchClass")) {
> 80: Assertions.assertEquals( "invalid
> jdk.serialFilterFactory: ForcedError_NoSuchClass:
> java.lang.ClassNotFoundException: ForcedError_NoSuchClass", msg, "wrong
> exception");
too many spaces
test/jdk/java/io/Serializable/serialFilter/SerialFilterFunctionTest.java line
108:
> 106: Assertions.assertThrows(NullPointerException.class, () ->
> ObjectInputFilter.allowFilter(predicate, expected));
> 107: } else {
> 108: Assertions.assertEquals( expected,
> ObjectInputFilter.allowFilter(predicate, otherStatus).checkInput(info),
> "Predicate result");
too man spaces
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2638091288
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2638091168
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2638091414
