On Thu, 18 Dec 2025 18:01:03 GMT, Chen Liang <[email protected]> wrote:
> The bitwise manipulation code in ImageDecompressor::getU8 and getU4 utilizes > implicit conversion to signed int for bitwise or, making this code confusing, > especially when the most significant bytes are explicitly converted to > unsigned long long, and unsigned long long takes part in a bitwise or with > int. We should convert all u1 to u8/u4 before shifts to make the code easier > to maintain and understand. This pull request has now been integrated. Changeset: ecb42341 Author: Chen Liang <[email protected]> URL: https://git.openjdk.org/jdk/commit/ecb42341a94326b1ee85ddd7b9ebadce8c952b99 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod 8373447: Suspicious sign extension after integer promotion in imageDecompressor.cpp Reviewed-by: alanb ------------- PR: https://git.openjdk.org/jdk/pull/28903
