On Tue, 23 Dec 2025 02:27:35 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Miscellaneous refactorings without functional changes: >> >> - Replace StringBuffer with StringBuilder where appropriate >> - LauncherBuilder: set reasonable defaults to "defaultIconResourceName" >> property; move `defaultIconResourceName()` from LauncherFromOptions >> - Make `MacHelper.createRuntimeBundle()` use PackageTest to create a runtime >> bundle. Will use DMG by default and optionally PKG packaging to create a >> runtime bundle >> - Remove redundat parameter from `SetBuilder.build()` >> - Make `JUnitUtils.assertArrayEquals()` permit null-s >> - Add `JPackageCommand.withToolProvider()` >> - Make some handy package-private methods in StandardBundlingOperation class >> public >> - BundleSpec: add "sealed" modifier >> - IdentityWrapper: add `wrapIdentity()` >> - Simplify `DefaultBundlingEnvironment.createNativePackage()` >> - TKit: remove "throws IOException" from `createDirectories()`; Replace >> `TKit.createDirectories()` with `Files.createDirectories()` where directory >> clean-up is not used > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > BasicTest: use Files.createDirectories() instead of TKit.createDirectories() Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/28957#pullrequestreview-3606368301
