On Tue, 23 Dec 2025 02:49:22 GMT, Alexander Matveev <[email protected]> 
wrote:

> - Removed `<key>plst</key>`. It is not clear why we need it.
> - I did not found official specification for this file, but based on some 
> research `<key>plst</key>` is not part of it. Other entries seems to be 
> required.
> - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are 
> no alternative for it.

Changes requested by asemenyuk (Reviewer).

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/lic_template.plist
 line 184:

> 182:                  <string>0x0000</string>
> 183:                  <key>Data</key>
> 184:                  
> <data>AAYFTm9yc2sERW5pZwlJa2tlIGVuaWcIU2tyaXYgdXQKQXJraXZlci4uLqNIdmlzIERlIGVyIGVuaWcgaSBiZXN0ZW1tZWxzZW5lIGkgZGVubmUgbGlzZW5zYXZ0YWxlbiwga2xpa2tlciBEZSBwjCAiRW5pZyIta25hcHBlbiBmb3IgjCBpbnN0YWxsZXJlIHByb2dyYW12YXJlbi4gSHZpcyBEZSBpa2tlIGVyIGVuaWcsIGtsaWtrZXIgRGUgcIwgIklra2UgZW5pZyIu</data>

I suppose this is a base64-encoded Norwegian translation of something. We don't 
support Norwegian l10n.

Supported l10n-s should be in .properties files and encoded as base64 at 
runtime.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28959#pullrequestreview-3606363972
PR Review Comment: https://git.openjdk.org/jdk/pull/28959#discussion_r2641780135

Reply via email to