On Fri, 26 Dec 2025 06:02:09 GMT, SendaoYan <[email protected]> wrote:

> So i think it's better to leave this check inside test, same like to 
> jdk/internal/platform/docker/TestSystemMetrics.java.

I don't think so.

Just imagine someone may call `MetricsTester.main(args)` again in the future, 
how can you prevent him/her not forgetting adding the check before the call?

That's why I would suggest adding it in the place where it requires docker 
directly, not the place indirectly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28996#issuecomment-3692221565

Reply via email to