On Tue, 6 Jan 2026 08:16:16 GMT, Volkan Yazici <[email protected]> wrote:
> Back out `java.lang.StringCoding` changes delivered in [JDK-8361842] (#25998 > & 655dc516c22), which causes regressions reported in [JDK-8374210]. > > [JDK-8361842]: https://bugs.openjdk.org/browse/JDK-8361842 > [JDK-8374210]: https://bugs.openjdk.org/browse/JDK-8374210 This does not look like a clean backout -- the incoming/outgoing line counts do not match against the original commit -- so extra caution is needed in reviews. Apart from the inadverent (?) addition in `JavaLangAccess.java`, there seem to be hunk differences in some `sun/nio/cs` files; I assume those are intentional? src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 455: > 453: * compatible. > 454: * <p> > 455: * <b>WARNING: This method does not perform any bound checks.</b> These two lines are not in the original commit? https://github.com/openjdk/jdk/commit/655dc516c22ac84fccee6b1fdc607c492465be6b#diff-bd92d760986b9249dd3c02cc147db4f7e9dbbef90afef4971ee497a50e48c740 ------------- PR Review: https://git.openjdk.org/jdk/pull/29055#pullrequestreview-3630055594 PR Review Comment: https://git.openjdk.org/jdk/pull/29055#discussion_r2664196789
