On Tue, 6 Jan 2026 20:17:45 GMT, Brian Burkhalter <[email protected]> wrote:
>> If on Windows and the `Space` constructor fails with a `RuntimeException`,
>> skip the volume if it is found not to exist. This has been found to be the
>> case for all errors observed recently which appear to be due to the presence
>> of transient volumes.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8372377: Change RuntimeException to IOException
test/jdk/java/io/File/libGetXSpace.c line 65:
> 63: const jchar* strchars = (*env)->GetStringChars(env, root, NULL);
> 64: if (strchars == NULL) {
> 65: JNU_ThrowByNameWithLastError(env, "java/io/IOException",
The update to have getSpace0 throw IOException is good. There are now 2 cases
in that native method where is throws IOException for non-I/O reasons,
specifically when GetStringChars or malloc fails. You might want to revert
those two as IOException doesn't make sense.
I assume the change to isCDDrive can be reverted too as it doesn't throw an
exception corresponding to an I/O error.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29052#discussion_r2666271741
