On Thu, 8 Jan 2026 12:30:46 GMT, Lance Andersen <[email protected]> wrote:
>> Do you mean additional comments for the enclosing `if` block? That piece of >> code is the same as what's currently present in the implementation of >> `readUShort(...)` except that we won't throw a `EOFException`. Would an >> additional comment like this be good: >> >> >> // read an unsigned short value representing the GZIP magic header. >> // this is the same as calling readUShort(in), except that here, >> // when reading the first byte, we don't raise an EOFException >> // if the stream has already reached EOF. > > Yes that is fine, just helps to,clarify given the code is outside readUShort > which will make things clearer for others later on Done, I've now updated the PR to add relevant comments and remove the assert. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29092#discussion_r2672337032
