On Tue, 13 Jan 2026 01:56:50 GMT, Roger Riggs <[email protected]> wrote:
>> Refactor serialization tests to use JUnit.
>> Automated conversion for most annotations.
>> Conditional tests are refactored to use JUnit Enable/DisableIf.
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains six additional
> commits since the last revision:
>
> - Merge branch 'master' into 8373913-serialfilter-to-junit
> - Refactored test parameter provider methods to be static.
> Removed the @TestInstance annotations.
> Added @Serial where it was missing.
> - Simplification of AssertThrows cases and changing success output to
> System.err to interleve with JUnit output.
> - Update to use Stream<List<String>> for parameterized method testing.
> Add static to simplify test setup.
> Small source changes to remove "C" style array declarations.
> - Cleanup arglist and fix code style
> - JDK-8373913: Refactor serialization tests tests to use JUnit
> Automated conversion for most annotations.
> Conditional tests are refactored to use JUnit Enable/DisableIf.
test/jdk/java/io/Serializable/records/RecordClassTest.java line 53:
> 51: * Serializes and deserializes record classes. Ensures that the SUID is 0.
> 52: */
> 53: @TestInstance(TestInstance.Lifecycle.PER_CLASS)
If we want to remove the class instance lifecycle here as well, should we make
`notSerRecordClasses()` static?
test/jdk/java/io/Serializable/serialFilter/SerialFactoryFaults.java line 78:
> 76:
> 77: if (factoryName.equals("ForcedError_NoSuchClass")) {
> 78: Assertions.assertEquals( "invalid
> jdk.serialFilterFactory: ForcedError_NoSuchClass:
> java.lang.ClassNotFoundException: ForcedError_NoSuchClass", msg, "wrong
> exception");
I think some of the white space issues which were left from the tool, pointed
out by @turbanoff earlier, still exist.
test/jdk/java/io/Serializable/serialFilter/SerialFilterTest.java line 399:
> 397: @ParameterizedTest
> 398: @MethodSource("invalidLimits")
> 399: @MethodSource("invalidLimits")
Duplicate method source added by accident?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2687379883
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2687383790
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2687387168
