On Mon, 12 Jan 2026 19:33:10 GMT, Alan Bateman <[email protected]> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to use Stream<List<String>> for parameterized method testing. >> Add static to simplify test setup. >> Small source changes to remove "C" style array declarations. > > test/jdk/java/io/Serializable/serialFilter/CheckArrayTest.java line 55: > >> 53: * The filterCheck must be resilent to an InputStream not being >> available (only the subclass knows). >> 54: */ >> 55: @TestInstance(TestInstance.Lifecycle.PER_CLASS) > > Looks like 9 other tests are using PER_CLASS, is that because of setup > methods and method sources that are instance rather than static methods? The helpful conversion tool added PER_CLASS, I assume due to the source methods were instance method. Use of PER_CLASS does not seem to be discouraged. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2683706953
