On Fri, 19 Dec 2025 20:22:10 GMT, Brent Christian <[email protected]> wrote:
> `RuntimeArguments.java` runs with `@requires vm.flagless`, though setting the
> `test.thread.factory=Virtual` system property with `-D` will still run the
> test.
>
> The test spawns java processes, checking for particular, exact sets of
> runtime options (hence, `vm.flagless`). It is not expecting to find
> `-Dtest.thread.factory=Virtual`.
>
> It doesn't seem important that this test be run with the virtual thread
> factory. The suggestion of adding this test to `ProblemList-Virtual.txt`
> seems reasonable. (It would be a long term resident of the problem list,
> which is perhaps a bit strange.)
>
> Alternative courses of action:
> * Teach the test itself to artificially pass in the presence of `-D` options.
> * Enhance the test so it knows how to expect `-D` options; offhand that
> doesn't seem worth it.
>
> Update:
> The bots don't like having the "current" bugid present in the problem list. I
> have updated the bugid in the PL to 8309303 (when the `VM_OPTIONS` constant
> was added to the test) - a bit disingenuous. If we're not happy with this, I
> guess a new issue could be filed ("RuntimeArguments.java doesn't account for
> -D system properties") to use in the problem list.
This pull request has now been integrated.
Changeset: 4d0ad0a4
Author: Brent Christian <[email protected]>
URL:
https://git.openjdk.org/jdk/commit/4d0ad0a4a391286c683ebb8c8d711ea0be68c31a
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
8373718: jdk/internal/misc/VM/RuntimeArguments.java test fails in Virtual
threads mode
Reviewed-by: alanb
-------------
PR: https://git.openjdk.org/jdk/pull/28935
