On Tue, 13 Jan 2026 22:42:41 GMT, Justin Lu <[email protected]> wrote:
> This PR converts the TestNG tests in _util/ServiceLoader_ (7), > _util/StringJoiner_ (3), and _util/Vector_ (1) to JUnit. > The first commit is from the automated tool, the rest are manual changes done > after. > > Before > ServiceLoader: Framework-based tests: 62 = 62 TestNG + 0 JUnit > StringJoiner: Framework-based tests: 32 = 32 TestNG + 0 JUnit > Vector: Framework-based tests: 9 = 9 TestNG + 0 JUnit > > After > ServiceLoader: Framework-based tests: 62 = 0 TestNG + 62 JUnit > StringJoiner: Framework-based tests: 32 = 0 TestNG + 32 JUnit > Vector: Framework-based tests: 9 = 0 TestNG + 9 JUnit LGTM. test/jdk/java/util/ServiceLoader/BadProvidersTest.java line 171: > 169: loadProviders(mods, TEST1_MODULE).forEach(Provider::get); > 170: }); > 171: } I think it is done by the tool, but I think retaining the blank lines may read better (and probably intended). test/jdk/java/util/ServiceLoader/BadProvidersTest.java line 201: > 199: // load providers and instantiate each one > 200: loadProviders(mods, TEST2_MODULE).forEach(Provider::get); > 201: }); Same here ------------- PR Review: https://git.openjdk.org/jdk/pull/29210#pullrequestreview-3658358364 PR Review Comment: https://git.openjdk.org/jdk/pull/29210#discussion_r2688496372 PR Review Comment: https://git.openjdk.org/jdk/pull/29210#discussion_r2688496964
