On Wed, 14 Jan 2026 04:55:05 GMT, Alexander Matveev <[email protected]> wrote:
>> - Fixed plist file so translation works. It did not worked before. >> - All strings which needs translations moved to .properties files. >> - Added translated strings, since it is required to have all of them. We >> cannot have English strings in localized files, since different charset is >> required for each language. >> - I tested all translations. >> - Adding same license text for all translations is required. >> - See JBS for screenshot of dialog. It is same except it now has drop down >> box with 4 languages we support. There are no way to remove it once >> translations implemented correctly in plist file. >> - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there >> are no alternative for it. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > Added missing import from merge Changes requested by asemenyuk (Reviewer). src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgPackager.java line 1: > 1: /* I suggest moving the license building code to a separate class. Say MacDmgLicense. This way, we will have the license-building code isolated in a separate class rather than a bunch of license-related methods scattered across the MacDmgPackager class. src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/lic_template.plist line 68: > 66: <string>5003</string> > 67: <key>Name</key> > 68: <string>Chinese (Simplified)</string> Shouldn't we have the values of the "Name" key localized too? ------------- PR Review: https://git.openjdk.org/jdk/pull/28959#pullrequestreview-3661821546 PR Review Comment: https://git.openjdk.org/jdk/pull/28959#discussion_r2691334472 PR Review Comment: https://git.openjdk.org/jdk/pull/28959#discussion_r2691322313
