On Mon, 29 Sep 2025 03:24:32 GMT, Eric Fang <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update callGenerator.hpp copyright year
>
> test/hotspot/jtreg/compiler/vectorapi/TestSliceOptValueTransforms.java line
> 101:
>
>> 99: .slice(0, ByteVector.fromArray(BSP, bsrc2, i))
>> 100: .intoArray(bdst, i);
>> 101: }
>
> Would you mind adding a correctness check for these tests, for byte type,
> like:
>
> @DontInline
> static void verifyVectorSliceByte(int origin) {
> for (int i = 0; i < BSP.loopBound(SIZE); i += BSP.length()) {
> int index = i;
> for (int j = i + origin; j < i + BSP.length(); j++) {
> Asserts.assertEquals(bsrc1[j], bdst[index++]);
> }
> for (int j = i; j < i + origin; j++) {
> Asserts.assertEquals(bsrc2[j], bdst[index++]);
> }
> }
> }
There are enough number of functional correctness tests in existing VectorAPI
JTREG suite, this test specifically checks for newly added VectorSlice IR node
and associated ideal transformations.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24104#discussion_r2703827513
