On Thu, 22 Jan 2026 16:30:03 GMT, Liam Miller-Cushon <[email protected]> wrote:

> Thanks, I agree with not doing #29075 separately first to avoid a breakage. 
> However doing this one first also doesn't work, this change by itself would 
> regress `tools/javac/lambda/SerializableObjectMethods.java` and 
> `tools/javac/lambda/LambdaLambdaSerialized.java`. Currently those tests rely 
> on lambdas being incorrectly merged together, and with this fix they no 
> longer get merged because they have different target types, but then they 
> don't deserialize because the `getImplClass` doesn't match. Those test 
> failures were what led me down the path of that other fix: 
> https://bugs.openjdk.org/browse/JDK-8208752?focusedId=14636922&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14636922
> 
> So I think maybe we should just merge both of these changes into a single 
> fix? I will update the PR if that makes sense.

Ah, OK. Then I would say merge the patches - if they cannot be separated, then 
merging/combining them is the only real option.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28943#issuecomment-3785380123

Reply via email to