On Mon, 26 Jan 2026 13:28:27 GMT, Adam Farley <[email protected]> wrote:

> This change ensures that the class "jtreg/SkippedException" can be found and 
> used by the test while running with versions of jtreg that are under 7.5.1+1.
> 
> 
> This has been tested elsewhere and seems to work well.
> Test configs:
> - JDK17 - jtreg 7.3.1+1
> - JDK25 - jtreg 7.5.1+1 
> 
> https://bugs.openjdk.org/browse/JDK-8376188

Thank you for the update, this looks OK to me from a jtreg test point of view.

Given the area, I will let someone from jpackage area to Review and approve 
this. Plus, 
`test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.throwSkippedException(...)`
 seems to dynamically define the `jtreg.SkippedException` 
https://github.com/openjdk/jdk/blob/master/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java#L1310,
 so I'm not sure what kind of impact (if any) this change would have on this or 
other tests in this area.

-------------

PR Review: https://git.openjdk.org/jdk/pull/29416#pullrequestreview-3706802055

Reply via email to