On Thu, 29 Jan 2026 18:08:03 GMT, Paul Sandoz <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments resolutions > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LaneType.java > line 88: > >> 86: final String printName; >> 87: final char typeChar; // one of "BSILFD" >> 88: final int laneType; // lg(size/8) | (kind=='F'?4:kind=='I'?8) > > We need to change the name of this field to more clearly distinguish between > it and the class name. > > If we can change the values of `LT_*` and align them with the enum ordinal > values then we can call it `laneTypeOrdinal` and consistently use that, then > we don't likely need the `LT_*` constants. If the values need to align with > `BasicType` values then it might be better called `laneTypeIdentifier` or > `laneTypeId`. Thanks @PaulSandoz , I have incorporated your comments, it will still be useful to keep new LT_* constants as its better to pass named constants to intrinsic entries rather than numeric values. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29481#discussion_r2745013458
