On Thu, 22 Jan 2026 00:41:13 GMT, Justin Lu <[email protected]> wrote:

> Please review this PR which converts the JDBC TestNG tests to use JUnit.
> 
> This is mainly done using the automated tool in 
> https://github.com/openjdk/jdk/commit/0cec3097aec02e72ccb6ebbf0b2b046220578d1b,
>  with some manual follow up commits. The testng folder is migrated to junit 
> with the TEST.properties updated as well. Most changes are annotation updates 
> and switching from testNG imports to JUnit. I decided to simplify cases of 
> `BaseTest.trueFalse()` to use booleans in a `ValueSource` directly in 
> https://github.com/openjdk/jdk/commit/757e7966666d39748db2912b32ccf8b1df18bd62.
> 
> Framework test stats before:
> 680 = 680 TestNG + 0 JUnit
> 
> Framework test stats after:
> 680 = 0 TestNG + 680 JUnit

This pull request has now been integrated.

Changeset: ee60eff1
Author:    Justin Lu <[email protected]>
URL:       
https://git.openjdk.org/jdk/commit/ee60eff1ec9eddcdedc12c1707fbcca0025e71d6
Stats:     20245 lines in 134 files changed: 10219 ins; 9841 del; 185 mod

8376038: Refactor java/sql tests to use JUnit
8376629: Refactor javax/sql tests to use JUnit

Reviewed-by: lancea

-------------

PR: https://git.openjdk.org/jdk/pull/29354

Reply via email to