On Fri, 30 Jan 2026 02:20:09 GMT, SendaoYan <[email protected]> wrote:
> Hi all,
>
> Test tools/jimage/VerifyJimage.java#compare intermittent timed out with
> fastdebug build. I think it would be better to ajust the jtreg timeout
> factor(20*timeoutFactor) rather that set the fix timeout value(20) for
> awaitTermination.
>
> The test run all passed 100 times simultaneously.
test/jdk/tools/jimage/VerifyJimage.java line 152:
> 150: long timeout = Utils.adjustTimeout(20);
> 151: if (!pool.awaitTermination(timeout, TimeUnit.SECONDS)) {
> 152: failed.add("Directory verification timed out in " +
> timeout + " seconds");
The alternative is to just replace the shutdown + awaitTermination with a call
to `pool.close()`. This will wait indefinitely, which is useful for
diagnosability if the verification hangs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29498#discussion_r2749755002
