On Tue, 3 Feb 2026 17:39:21 GMT, Naoto Sato <[email protected]> wrote:
>> test/jdk/java/io/Console/ReadWriteBlockingTest.java line 66: >> >>> 64: jdkDir + "/bin/java", >>> 65: "-classpath", testClasses, >>> 66: "ReadWriteBlockingTest"); >> >> I think it's an oversight that the `-Djdk.console=jdk.internal.le` system >> property is being set in the `@run` of this test definition instead of being >> passed here to the launched `java` application. I think the test might have >> to be refactored a bit to have one single `@run ....` and then here in the >> test method launch the `java` main() with and without that system property. > > Good catch! Thanks. The test was not running jline indeed. Now the system > property is passed down to the java launcher so that the test correctly > checks for both java.base and jline implementations. I think keeping the test > run separately would help diagnose the jtreg logs. A parameterized test with a string value source containing the two property values would also be a concise way to have helpful Jtreg logs if we wanted to keep it to a single `@run`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29493#discussion_r2760560771
