On Tue, 10 Feb 2026 02:03:29 GMT, Joe Darcy <[email protected]> wrote:
>> @jddarcy What is the purpose of such methods that do not seem to be invoked? > >> @jddarcy What is the purpose of such methods that do not seem to be invoked? > > I'm a bit confused; they do look to be used in that test file; e.g. > > https://github.com/openjdk/jdk/blame/f9ded7f88cce75151cec32d1ef1f9662ea10431a/test/jdk/java/lang/Math/HyperbolicTests.java#L251 > > ` failures += testSinhCaseWithUlpDiff(testCase[0],` > @jddarcy The concern is methods testing with tolerance, e.g. > `testSinhCaseWithTolerance`. That one is never used. Same for > `testCoshCaseWithTolerance`, `testTanhCaseWithTolerance`. If they are to be > removed, I suggest to make is in a separate cleanup PR. Ah, okay. Looking at the history, those methods were including in the initial drop of files to OpenJDK and probably date back to when the hyperbolics were added in JDK 5. Without looking back at the ancient history, those methods might support test cases that were replaced by other test or written in anticipation of tests that were not written. I think removing them in a follow-up pass is fine. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2789080207
