Re: RFR: 8376665: Port fdlibm acosh to Java [v8]

[Andrey Turbanov]

On Thu, 12 Feb 2026 08:45:14 GMT, Anton Artemov <aarte...@openjdk.org> wrote:

>> Hi, please consider the following changes:
>> 
>> This is a port of FDLIBM acosh method.
>
> Anton Artemov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8376665: Addressed reviewer's comments.

src/java.base/share/classes/java/lang/FdLibm.java line 3591:

> 3589:             int hx;
> 3590:             hx = __HI(x);
> 3591:             if(hx < 0x3ff0_0000) {                           // x < 1 */

Suggestion:

            if (hx < 0x3ff0_0000) {                           // x < 1 */

src/java.base/share/classes/java/lang/FdLibm.java line 3594:

> 3592:                 return (x - x) / (x - x);
> 3593:             } else if (hx >= 0x41b0_0000) {                  // x > 
> 2**28
> 3594:                 if(hx >= 0x7ff0_0000) {                      // x is 
> inf of NaN

Suggestion:

                if (hx >= 0x7ff0_0000) {                      // x is inf of NaN

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29488#discussion_r2798021724
PR Review Comment: https://git.openjdk.org/jdk/pull/29488#discussion_r2798022331