On Fri, 13 Feb 2026 02:00:09 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which introduces a test to verify > the usages of `@since` javadoc tags in the `java.naming` module? This > addresses https://bugs.openjdk.org/browse/JDK-8377857. > > The `SinceChecker` test utility has been in use for several modules, but > wasn't added for java.naming. The commit in this PR adds one for that module. > > The `SinceChecker` test utility does not handle the presence of a comma in > (for example `@since X, Y`) correctly. The javadoc tag spec for `@since` > allows that syntax > https://docs.oracle.com/en/java/javase/25/docs/specs/javadoc/doc-comment-spec.html#since. > As a workaround, the commit in this PR splits the `@since` on > `javax.naming.InitialContext` class into two separate declarations (this too > is allowed by the `@since` tag spec). I've verified that the generated > javadoc continues to correctly show these values. I have also spoken to Nizar > about this issue in SinceChecker and it will be addressed separately. src/java.naming/share/classes/javax/naming/InitialContext.java line 121: > 119: * NamingManager.setInitialContextFactoryBuilder > 120: * @since 1.3 > 121: * @since JNDI 1.1 Do we really need to keep `@since JNDI 1.1`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29705#discussion_r2802901491
