On Fri, 13 Feb 2026 06:33:44 GMT, Jatin Bhateja <[email protected]> wrote:
>> As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on >> JDK-8370691 pull request, splitting out portion of PR#28002 into a separate >> patch. >> >> In preparation of Float16 vector API support, changes to nomenclature of >> concrete vector class by suffixing the vector type with vector bit sizes >> e.g. FloatVector256 so that we don't end up generating names like >> Float16256Vector. >> >> All existing Vector API jtreg test are passing with the patch. >> >> Kindly review and share your feedback. >> >> Best Regards, >> Jatin > > Jatin Bhateja has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments resolution Looks good, just one last comment to address. No need for another review. src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java line 142: > 140: String suffix = suffix(vspecies); > 141: String elemType = (vspecies.elementType() == float.class ? > "f" : ""); > 142: boolean isFloat64Vector = (vspecies.elementType() == > float.class) && (vspecies.length() == 2); // FloatVector64 or FloatVectorMax Change the variable name too, here and at line 214. ------------- PR Review: https://git.openjdk.org/jdk/pull/29614#pullrequestreview-3798632429 PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2805367818
