On Sat, 14 Feb 2026 02:37:25 GMT, Kirill Shirokov <[email protected]> wrote:
>> The fix removes duplicate `-agent...` and `-javaagent:...` options from test >> subprocess command line, thus allowing to run jtreg tests with agents that >> should be specified only once. >> >> The fix tested manually: >> >> >> $ make test JTREG="VERBOSE=summary,fail,error" >> TEST="test/jdk/sun/tools/jstack/DeadlockDetectionTest.java >> test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java >> test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java" >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> SKIP >> jtreg:test/jdk/sun/tools/jstack/DeadlockDetectionTest.java >> 1 1 0 0 >> 0 >> jtreg:test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java >> 1 1 0 0 >> 0 >> jtreg:test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java >> 1 1 0 0 >> 0 >> ============================== >> TEST SUCCESS >> >> $ make test >> JTREG="VERBOSE=summary,fail,error;JAVA_OPTIONS=-agentpath.../async-profiler-binaries/lib/libasyncProfiler.dylib=start,event=cpu,cstack=vm,loglevel=none,flat,file=/dev/null" >> TEST="test/jdk/sun/tools/jstack/DeadlockDetectionTest.java >> test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java >> test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java" >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> SKIP >> jtreg:test/jdk/sun/tools/jstack/DeadlockDetectionTest.java >>>> 1 0 1 0 >>>> 0 << >> jtreg:test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java >>>> 1 0 1 0 >>>> 0 << >> jtreg:test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java >>>> 1 0 1 0 >>>> 0 << >> ============================== >> TEST FAILURE >> >> $ make test >> JTREG="VERBOSE=summary,fail,error;VM_OPTIONS=-agentpath:.../async-profiler-binaries/lib/libasyncProfiler.dylib=start,event=cpu,cstack=vm,loglevel=none,flat,file=/dev/null" >> TEST="test/jdk/sun/tools/jstack/DeadlockDetectionTest.java >> test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java test/... > > Kirill Shirokov has updated the pull request incrementally with two > additional commits since the last revision: > > - Remove trailing whitespace > - Removed duplicate VM options from > test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java, > test/jdk/sun/tools/jstack/DeadlockDetectionTest.java, > test/lib/jdk/test/lib/apps/LingeredApp.java, > test/lib/jdk/test/lib/cli/CommandLineOptionTest.java. Added duplicate agent > options warning to ProcessTools-spawned subprocesses and LingeredApp Thanks for fixing tests. The fix looks good. ------------- Marked as reviewed by lmesnik (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29684#pullrequestreview-3801076153
