On Mon, 16 Feb 2026 14:46:09 GMT, Raffaello Giulietti <[email protected]>
wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More `indexOf` et al. guards and other review feedback
>
> src/java.base/share/classes/java/lang/StringLatin1.java line 475:
>
>> 473: return 0;
>> 474: }
>> 475: if (value.length == 0) {
>
> These checks could be removed altogether, and instead rely on those in the
> invoked method.
>
> Alternatively, this line could be
> Suggestion:
>
> if (value.length < str.length) {
>
> to match
> https://github.com/openjdk/jdk/pull/28832/changes#diff-0429b143c93fceff618ecb5bb78b584f2b2ea4771241c7dd450ddb9151c1c515R511
> more closely.
Right. Removed the checks in 0966a6617d4.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28832#discussion_r2813738888
