On Thu, 19 Feb 2026 16:04:34 GMT, Lance Andersen <[email protected]> wrote:

> WRT the test, it is preferable that the ZipFS tests are added to 
> open/test/jdk/jdk/nio/zipfs for now so that we have the specific tests 
> co-located.

The existing `EndOfCenValidation` test goes through  some heroic efforts to 
create ZIP/ZIP64 files under reasonable size and efficiency constraints that 
provokes these edge-cases being tested. 

The reason I opted to expand the existing test with support for verifying 
`ZipFileSystem` was based on the following observations:

* We want to ensure that validation for these cases is equivalent across APIs
* Co-locating them avoids duplication of good amounts of intricate setup of 
test vectors

Did you mean that we should copy this tests and maintain the copy separately in 
the `zipfs` area?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29747#issuecomment-3928397967

Reply via email to