On Tue, 3 Mar 2026 06:06:03 GMT, Jatin Bhateja <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename testcase
>
>> I confirmed following patch fixes the problem, and the test passed. May I
>> send PR?
>>
>> ```diff
>> diff --git
>> a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>>
>> b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>> index d6763c2c03a..95fe8ca35db 100644
>> ---
>> a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>> +++
>> b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>> @@ -772,7 +772,7 @@ public abstract class $abstractvectortype$ extends
>> AbstractVector<$Boxtype$> {
>> @ForceInline
>> final
>> $abstractvectortype$ unaryMathOp(VectorOperators.Unary op) {
>> - return VectorMathLibrary.unaryMathOp(op, opCode(op), species(),
>> $abstractvectortype$::unaryOperations,
>> + return VectorMathLibrary.unaryMathOp(op, opCode(op), vspecies(),
>> $abstractvectortype$::unaryOperations,
>> this);
>> }
>> #end[FP]
>> @@ -983,7 +983,7 @@ public abstract class $abstractvectortype$ extends
>> AbstractVector<$Boxtype$> {
>> @ForceInline
>> final
>> $abstractvectortype$ binaryMathOp(VectorOperators.Binary op,
>> $abstractvectortype$ that) {
>> - return VectorMathLibrary.binaryMathOp(op, opCode(op), species(),
>> $abstractvectortype$::binaryOperations,
>> + return VectorMathLibrary.binaryMathOp(op, opCode(op), vspecies(),
>> $abstractvectortype$::binaryOperations,
>> this, that);
>> }
>> #end[FP]
>> ```
>
> I created PR https://github.com/openjdk/jdk/pull/30012 but closed that, I
> think there is some issue in tooling while creating a patch against .template
> file. May I request you to kindly create a pull request for fix.
@jatin-bhateja
Can I make PR with the patch in above?
I did not see any issues with it, and also I confirmed gen-src.sh generates
source files which are same with files in HEAD.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29835#issuecomment-3990703927
