On Fri, 27 Feb 2026 18:45:16 GMT, Naoto Sato <[email protected]> wrote:
>> Sruthy Jayan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix alignment issue >> >> Signed-off-by: Sruthy Jayan <[email protected]> >> - Refactor function name for clarity and fix memory allocation issues >> >> Signed-off-by: Sruthy Jayan <[email protected]> > > I don't have any knowledge on AIX's TZ mappings, so I just left generic > comments. @naotoj Could you please review. I have addressed the review comments > This function name is kind of vague as to what it actually does. More > specific name would be preferred. Refactored function name for clarity. > Is this malloc needed? Is `tz_buf` already allocated by the above `strdup` > with full length? If for some reason it needs to reallocate a new buffer, > previously allocated buffer needs to be freed. memory allocation issue is fixed ------------- PR Comment: https://git.openjdk.org/jdk/pull/29183#issuecomment-3995559661 PR Review Comment: https://git.openjdk.org/jdk/pull/29183#discussion_r2882040857 PR Review Comment: https://git.openjdk.org/jdk/pull/29183#discussion_r2882041811
