On Thu, 5 Mar 2026 15:31:02 GMT, Christian Stein <[email protected]> wrote:
> Please review this change to use JUnit API in `MethodTemplateTest.java`. As > only simple `assertTrue` and `assertFalse` are being called in test code, a > swap of packages in `import` statements suffices. > > This pull request also disallows `testng` actions in `jtreg` under this test > root to prevent future additions of TestNG-based tests. See the umbrella > issue https://bugs.openjdk.org/browse/JDK-8307843 and its associated subtasks > for details. Marked as reviewed by dfuchs (Reviewer). I am not a typical Reviewer for that area, so maybe wait for someone who's worked on this codebase before to approve, before integrating. That said, having already converted a few TestNG tests to JUnit myself, I had a look at your proposed changes and they looked good. I verified that there was not `assertEquals` that would have required swapping the parameter order, and therefore no need to replace `assertEquals` with `assertArrayEquals` anywhere either. So LGTM. ------------- PR Review: https://git.openjdk.org/jdk/pull/30087#pullrequestreview-3897585869 PR Comment: https://git.openjdk.org/jdk/pull/30087#issuecomment-4005957563
