> A few jpackage tests have issues that don't show up when executed in the 
> regular JDK test environment but fail in the local dev test environment:
> 
>  - MainTest#testFailedCommandOutput() unit test will fail if 
> "jpackage.test.runtime-image" system property is set to skip jlink invocation.
> 
>  - A few test cases from SigningRuntimeImagePackageTest will fail if DMG 
> bundling is disabled ("jpackage.test.disabledPackagers: system property is 
> set to "dmg").
> 
>  - Most of macOS signing tests are broken if executed on older macOS 
> (Catalina). Even though this is an unsupported macOS version, it likely means 
> these tests may fail on other macOS versions. It is difficult to determine 
> which macOS version the problem first showed up in because these tests are 
> skipped by default.
> 
> This PR fixes the above issues identified in the JBS CR.
> 
> Additionally, fix LicenseTest so it works when both DEB and RPM packaging are 
> enabled; Remove `TKit.createRelativePathCopy()`; other changes are a 
> follow-up.

Alexey Semenyuk has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains four commits:

 - LicenseTest: make it work when both DEB and RPM packagings are enabled; 
TKit: remove clunky createRelativePathCopy(); follow-up changes.
 - Tweaks to make signing tests work on Catalina
 - SigningRuntimeImagePackageTest: fix test failure when DMG bundling is 
disabled and the test uses PKG bundling to create signed predefined runtime 
bundle.
 - cli/MainTest: fix testFailedCommandOutput() to make it pass when running the 
test with run_tests.sh jpackage test runner with the specified external runtime

-------------

Changes: https://git.openjdk.org/jdk/pull/30081/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=30081&range=01
  Stats: 225 lines in 8 files changed: 114 ins; 68 del; 43 mod
  Patch: https://git.openjdk.org/jdk/pull/30081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/30081/head:pull/30081

PR: https://git.openjdk.org/jdk/pull/30081

Reply via email to