On Fri, 6 Mar 2026 01:58:46 GMT, Alexander Matveev <[email protected]> wrote:
>> Alexey Semenyuk has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains two new commits since the last revision:
>>
>> - Update copyright year
>> - JPackageCommand: add standard assert to check that jpackage's output
>> doesn't contain the "wrong Linux package architecture" error
>
> src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties
> line 63:
>
>> 61: error.unexpected-package-property=Expected value of "{0}" property is
>> [{1}]. Actual value in output package is [{2}]. Looks like the value of
>> "{0}" property is hardcoded in "{3}" file in the resource directory
>> 62: error.unexpected-package-property.advice=Use [{0}] pattern string
>> instead of hard coded value [{1}] of {2} property in custom "{3}" file
>> 63: error.unexpected-default-package-property.advice=Don''t explicitly set
>> value of "{0}" property in custom "{1}" file
>
> Why two '' in `Don''t?`
Because the first quote escapes the second one. See
https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/text/MessageFormat.html#quoting-rules-in-patterns-heading.
Without quoting, the format string is printed as `Dont explicitly set value of
{0} property in custom "{1}" file` and format arguments are ignored. Note how
`Don't` turns into `Dont` and formatting elements (`{0}`, and `{1}`) printed as
is without being replaced by the arguments.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30085#discussion_r2893599561
