On Fri, 6 Mar 2026 23:33:30 GMT, David Beaumont <[email protected]> wrote:
> 95% automated migration (search and replace).
> A handful of slightly note-worthy tweaks (called out with inline comments).
>
> The majority/automated changes are:
> * Convert to JUnit assertions (oddly, very few places)
> * Convert to JUnit data providers (almost all tests)
> * Convert test to use assertThrows (many tests)
> * Make util methods static (needed for data providers, but done everywhere
> for consistency)
> * Organise imports
test/jaxp/javax/xml/jaxp/libs/catalog/CatalogTestUtils.java line 112:
> 110: // Gets the paths of the specified catalogs.
> 111: private static URI[] getCatalogPaths(String... catalogNames) {
> 112: return catalogNames == null
Null was never possible here because caller already checked.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30124#discussion_r2898441811
