On Fri, 6 Mar 2026 11:32:53 GMT, Raffaello Giulietti <[email protected]> 
wrote:

>> test/jdk/java/util/Arrays/AsList.java line 44:
>> 
>>> 42: import org.junit.jupiter.params.provider.MethodSource;
>>> 43: 
>>> 44: @TestInstance(TestInstance.Lifecycle.PER_CLASS)
>> 
>> Just curious why this is needed as the method source is a static method.
>
> This test was converted by an automated tool, and this line was added by it.
> I agree that it is not that useful in _this_ case, but doesn't seem to hurt 
> either.

Just a passing concern that some future maintainer will wonder if these tests 
have something subtle to require them to run with the same test case instance.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30111#discussion_r2899352089

Reply via email to