Re: RFR: 8379437: Refactor ProcessBuilder and ProcessHandle tests to JUnit

[Jaikiran Pai]

On Sat, 7 Mar 2026 13:49:47 GMT, Roger Riggs <rri...@openjdk.org> wrote:

> Refactor ProcessBuilder and ProcessHandle tests to use Junit instead of 
> TestNG.
> Remove old main testng driver stubs that allowed tests to be run from the 
> command line.

test/jdk/java/lang/ProcessBuilder/InheritIOTest.java line 53:

> 51:              new Object[] { List.of("InheritIOTest$TestRedirectInherit", 
> "printf", EXPECTED_RESULT_STDOUT) }
> 52:         };
> 53:     }

This method could be refactored as:


import org.junit.jupiter.params.provider.Arguments;
...
static List<Arguments> testCases() {
        return List.of(
                Arguments.of(List.of("InheritIOTest$TestInheritIO", "printf", 
EXPECTED_RESULT_STDOUT));
                Arguments.of(List.of("InheritIOTest$TestInheritIO", "printf", 
EXPECTED_RESULT_STDOUT));
        );
}


But if you prefer it in the current form, that's fine with me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30128#discussion_r2902826193