On Wed, 11 Mar 2026 16:56:08 GMT, Daniel Fuchs <[email protected]> wrote:

>> src/java.logging/share/classes/java/util/logging/LogManager.java line 754:
>> 
>>> 752:                 // implementation as a handler class may be only 
>>> visible to LogManager
>>> 753:                 // subclass for the custom log manager case
>>> 754:                 processParentHandlers(logger, name, visited);
>> 
>> This looks reasonable to me. There's one more location where 
>> processParentHandlers(...) is getting called in this class. Do you think 
>> that would need similar attention?
>
> I don't tink so because it passes a non trivial `visited` predicate that will 
> store loggers into a map... Hmmm... but maybe we need a reachability fence to 
> make sure that predicate is not GC'ed too early. Let me have a look.

I believe we're fine there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30185#discussion_r2919776001

Reply via email to