On Fri, 13 Mar 2026 15:02:04 GMT, Roger Riggs <[email protected]> wrote:
>> When an `OutputAnalyzer` instance uses a `LazyOutputBuffer` impl to capture
>> a process' standard output, it unconditionally writes progress logs to
>> stdout. This can easily flood the output in tests that spawn a great number
>> of processes, each with an OutputAnalyzer attached, as part of their
>> operations.
>>
>> This change introduce an optional "quiet mode" which allows suppressing the
>> diagnostic messages emitted by the analyzer.
>>
>> (Notes on implementation)
>> * Introducing a "verbose mode" instead would likely have been more
>> idiomatic, but would have implied a lot of existing tests opting into this
>> new mode to retain their current printing behavior.
>> * It is implemented as an extra parameter in new constructor overloads for
>> `OutputAnalyzer`, which really is the only way since `LazyOutputBuffer`
>> starts logging in its constructor.
>
> test/lib/jdk/test/lib/process/OutputBuffer.java line 148:
>
>> 146:
>> 147: private final void logProgress(String state) {
>> 148: if (!quiet) {
>
> 4-space indent.
`OutputBuffer.java` uses 2 char indent for some reason; I assume in this
particular case, it is better to stay consistent with the rest of the existing
code?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30238#discussion_r2932895552
