On Mon, 16 Mar 2026 14:55:03 GMT, Emanuel Peter <[email protected]> wrote:
>> Sandhya Viswanathan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> library_call.cpp changes not needed after Objects.checkIndex arguments >> fixed > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java > line 2039: > >> 2037: break; >> 2038: default: >> 2039: throw wrongPartForSlice(part); > > Did we "optimize away" the out of bounds check in this patch? > I think after this patch `wrongPartForSlice` is dead code. > I'm going to fix it with https://github.com/openjdk/jdk/pull/30113, and add > some tests too. There is a call to Objects.checkIndex() in sliceTemplate() which does out of bounds check (e.g. ByteVector.java). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/3804#discussion_r2943730146
