On Tue, 17 Mar 2026 07:24:03 GMT, Damon Fenacci <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use `write` instead of `insert` in `putChar` docs
>
> src/hotspot/share/opto/library_call.cpp line 1547:
>
>> 1545: bool LibraryCallKit::inline_string_toBytesU() {
>> 1546: // Get the arguments.
>> 1547: assert(callee()->signature()->size() == 3, "character array encoder
>> requires 3 arguments");
>
> Good idea! Could we add it to `getChars0` for consistency?
Good call. 6124a888a4d adds checks for `callee()->signature()->size()` to all
`StringUTF16` intrinsics. That is, `getChars0`, `getChar`, and `putChar` is
guarded too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30139#discussion_r2945087596
