On Fri, 13 Mar 2026 14:48:47 GMT, Christoph Langer <[email protected]> wrote:
> If a downstream OpenJDK build uses a different default setting for security > property "jdk.includeInExceptions" with regards to jar files, the test > java/util/jar/Manifest/IncludeInExceptionsTest.java will fail. > > However, since the test's purpose is not to check the default value but > rather the functionality, it could be made agnostic to the default. > > The test now has 3 iterations, one with "-Djdk.includeInExceptions=jar", one > with "-Djdk.includeInExceptions=" (empty) and one without > "jdk.includeInExceptions" set, which will be the default value of the JDK > distribution. Maybe put the new org.junit.jupiter to the other existing ones ? Otherwise looks good. ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30241#pullrequestreview-3959004139
