Hello,

This PR removes the code related to the client emulation mode, which was 
deprecated through the deprecation of its interface, the 
`NeverActAsServerClassMachine` and `AlwaysActAsServerClassMachine` flags in 
[JDK-8370843](https://bugs.openjdk.org/browse/JDK-8370843) and obsoleted in 
[JDK-8379665](https://bugs.openjdk.org/browse/JDK-8379665).

Much of the changes in this commit reverts the commits part of 
[JDK-8166002](https://bugs.openjdk.org/browse/JDK-8166002). For some reason 
there are several commits tied to this issue: 
https://github.com/openjdk/jdk/commit/0ac0d9ac29c0226fce7a965163e96e2a536d3716, 
https://github.com/openjdk/jdk/commit/197ce5bafabd12ec7ae6d8542188fea17358bacb

A semantic issue around the JTREG test property `vm.emulatedClient` is that it 
checks if the compilation mode is set to "quick-only", which the client 
emulation mode code sets it to. However, a user might enable the quick-only 
mode with `-XX:CompilationMode=quick-only`, without enabling the rest of the 
client emulation mode features. When removing `vm.emulatedClient`, some tests 
can now be run with `-XX:CompilationMode=quick-only`. So `vm.emulatedClient` 
really means "running with C1 enabled". Looking back at when this code was 
added in [JDK-8166002](https://bugs.openjdk.org/browse/JDK-8166002) this seems 
to have been intentional, but nontheless confusing.

My suggestion is that we remove the client emulation mode by reverting many of 
the changes from [JDK-8166002](https://bugs.openjdk.org/browse/JDK-8166002), 
and file follow-up issue(s) to look at adding more robust/correct/precise 
@requires-lines to the tests.

Testing:
* Oracle's tier1-4
* Local testing making sure that all the changed tests run out of the box

-------------

Commit messages:
 - Update test catalogue
 - 8380281: Remove the client emulation mode

Changes: https://git.openjdk.org/jdk/pull/30297/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=30297&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8380281
  Stats: 196 lines in 62 files changed: 0 ins; 108 del; 88 mod
  Patch: https://git.openjdk.org/jdk/pull/30297.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/30297/head:pull/30297

PR: https://git.openjdk.org/jdk/pull/30297

Reply via email to