On Wed, 18 Mar 2026 22:42:39 GMT, Sandhya Viswanathan
<[email protected]> wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename IR match nodes in tests to account for merging of scalar min/max
>> definitions in x86.ad file.
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 13426:
>
>> 13424: }
>> 13425:
>> 13426: void Assembler::vminmaxss(XMMRegister dst, KRegister mask,
>> XMMRegister nds, XMMRegister src, bool merge, int imm8) {
>
> To follow the convention of AVX512/AVX10.2 instruction naming, we should name
> this as evminmaxss. Likewise for other AVX10.2 instructions.
I renamed the ones not following the convention. Please let me know if I missed
any.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29831#discussion_r2962319921
