On Fri, 20 Mar 2026 12:31:41 GMT, Jaikiran Pai <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> initCause original exception
>
> test/jdk/java/util/zip/ZipOutputStream/UnmappableZipEntryNameOrComment.java
> line 75:
>
>> 73: ZipEntry e = new ZipEntry("file.txt");
>> 74: e.setComment(UNMAPPABLE);
>> 75: assertDoesNotThrow(() -> {
>
> Same comment here and the other places this is used. Given how many times
> it's used, I'm now starting to wonder if there's something I am missing about
> this usage.
I share your sentiment about this method. Usually better to just propagate, any
exception will point to where things went wrong.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30319#discussion_r2965605304
